Skip to content

util: use Map.prototype.getOrInsert() in circular reference formatting - #67451

Open
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:util-inspect-mapupsert
Open

util: use Map.prototype.getOrInsert() in circular reference formatting#67451
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:util-inspect-mapupsert

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Nov 13, 2026

Copy link
Copy Markdown
Member

Minor refactoring. Native upsert is available starting from v26.x.

@LiviaMedeiros
util: use Map.prototype.getOrInsert() in circular reference formatting
be3f91c 
Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros LiviaMedeiros added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 13, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Nov 13, 2026
@codecov

codecov Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (7b4c9e3) to head (be3f91c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #67451    +/-   ##
========================================
  Coverage   90.71%   90.72%            
========================================
  Files         801      802     +1     
  Lines      281889   282100   +211     
  Branches    54315    54352    +37     
========================================
+ Hits       255709   255925   +216     
- Misses      16307    16312     +5     
+ Partials     9873     9863    -10
Files with missing lines Coverage Δ
lib/internal/util/inspect.js 97.03% <100.00%> (-0.01%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/79039/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros @nodejs-github-bot @ljharb @bjohansebas